Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bands from protocol: fix bands_kpoints overrides #1021

Merged
merged 1 commit into from
Mar 27, 2024

Conversation

bastonero
Copy link
Collaborator

Fixes #1020

The bands_kpoints wouldn't be override if specified in the overrides and passed to the PwBandsWorkChain.get_builder_from_protocol. If specified, it is chosen instead of the bands_kpoints_distance.

The `bands_kpoints` wouldn't be override if specified in the overrides and
passed to the PwBandsWorkChain.get_builder_from_protocol. If specified,
it is chosen instead of the `bands_kpoints_distance`.
@bastonero bastonero requested a review from sphuber March 27, 2024 17:40
Copy link
Contributor

@sphuber sphuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bastonero

@sphuber sphuber merged commit ae7d248 into aiidateam:main Mar 27, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PwBandsWorkChain: the get_builder_from_protocol does not override bands_kpoints
2 participants